vcenter-event-broker-appliance icon indicating copy to clipboard operation
vcenter-event-broker-appliance copied to clipboard

feat: Add example Carbon Black function

Open darrylcauldwell opened this issue 2 years ago • 3 comments

Closes: #866 Signed-off-by: Darryl Cauldwell [email protected]

Summary

Please describe your changes and what you plan to introduce as part of this pull request submission. If it fixes a bug or resolves a feature request, be sure to link to the issue numbers following the template below.

We are looking to trigger a function when VmCreatedEvent event occurs which trigger software installation once guest OS is booted AND VMware Tools is running. The time between event and state where software install can be performed will depend on VM startup time.

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

  • [X] Please ensure that you are making a pull request against the Development branch
  • [X] Please use the WIP keyword in the title of your PR if you are not ready for review
  • [X] Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
  • [X] Please ensure that you have signed all commits and that you have squashed all relevant commits related to your change
  • [X] Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
  • [X] Please include any relevant screenshots and/or output as part of your testing
  • [X] Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [X] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation changes
  • [ ] Other (please describe):

Resolved Issues

List of Issues closed or resolved by this PR. Add multiple Closes keyword followed by the issue number (e.g. Closes #ISSUE-NUMBER)

Closes #ISSUE-NUMBER

Testing Verification

  • Short summary of testing (e.g. successfully built and deployed VMware Event Broker Appliance)
  • Please include any relevant screenshots and/or output as part of the testing

Additional Information

  • Any other details you wish to include or mention

If you have any questions/comments, feel free to reach out to team on Slack #vcenter-event-broker-appliance

Thank you from the VEBA Team! 🥳

darrylcauldwell avatar Jul 18 '22 13:07 darrylcauldwell

@darrylcauldwell not sure what happened but you opened a new PR and looks like some (most?) of the feedback from the previous PR (#885) hasn't been incorporated.

Could you please verify? Also, not sure if you intended to have certain CB URLs/company IDs in the examples/ini files. Those should be faked, e.g. replace-me.

embano1 avatar Jul 29 '22 15:07 embano1

Yes you are correct, I have just updated to remediate previous PR comments

  • Added syntax highlighting to filenames within README.md.
  • Changed to .
  • It was intended that the app logger level reads .info and not .debug, logging outputs meaningful messages at INFO and increased verbose messages at DEBUG so should only be turned on when debugging not as default.
  • The CompanyCode wasn’t sensitive as test org but changed as this would be customer specific.
  • Added exception around SlackWebhook.
  • Fixed typos in instance and immediately.
  • Updated all functions to NOT scale to zero and run min=1.

darrylcauldwell avatar Aug 02 '22 12:08 darrylcauldwell

Will look to squash changes into commit and let you know when complete.

darrylcauldwell avatar Aug 02 '22 12:08 darrylcauldwell

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

github-actions[bot] avatar Nov 03 '22 00:11 github-actions[bot]

Closing pull request due to inactivity. Please reopen if needed

github-actions[bot] avatar Dec 04 '22 00:12 github-actions[bot]