Issue 889

[dsbibby]

Summary

Draft PR for visibility and comment while working on #889

Pull Request Checklist

🚨 Please review the guidelines for contributing to this repository.

• [ ] Please ensure that you are making a pull request against the Development branch
• [ ] Please use the WIP keyword in the title of your PR if you are not ready for review
• [ ] Please ensure that you have opened a Github Issue if you are resolving/fixing a problem
• [ ] Please ensure that you have signed all commits and that you have squashed all relevant commits related to your change
• [ ] Please make sure that you have tested your change locally by successfully building and deploying the VMware Event Broker Appliance and/or building and deploying VMware Event Router
• [ ] Please include any relevant screenshots and/or output as part of your testing
• [ ] Please include any documentation updates that is applicable for your changes

Change Type

What types of changes does your code introduce to the VMware Event Broker Appliance?

Put an x in all boxes that apply

Please check the type of change your PR introduces:

• [ ] Bugfix (non-breaking change which fixes an issue)
• [ ] Feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Build related changes
• [ ] Documentation changes
• [ ] Other (please describe):

Resolved Issues

List of Issues closed or resolved by this PR. Add multiple Closes keyword followed by the issue number (e.g. Closes #ISSUE-NUMBER)

Closes #ISSUE-NUMBER

Testing Verification

• Short summary of testing (e.g. successfully built and deployed VMware Event Broker Appliance)
• Please include any relevant screenshots and/or output as part of the testing

Additional Information

• Any other details you wish to include or mention

If you have any questions/comments, feel free to reach out to team on Slack #vcenter-event-broker-appliance

Thank you from the VEBA Team! 🥳

[embano1]

@dsbibby @lamw is this something we want to get in for v0.7.3 or later?

[dsbibby]

@dsbibby @lamw is this something we want to get in for v0.7.3 or later?

I think @lamw already added the linked issue to the 0.8.0 milestone. Certainly I have a lot more work to do on this and there's likely some minor breaking changes.

More commits coming soon here :)

[vmwclabot]

@dsbibby, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 8434bb19e62b29c7819a2df74fc5d8dd3648e4e0 must be signed by [email protected]

[vmwclabot]

@dsbibby, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <[email protected]> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

• Commit 0b8dd4fe9c00a72df0c8f3408d78acc776ddbf42 must be signed by [email protected]

[dsbibby]

Update on this PR: I'll leave this draft here for now to allow further review of the changes being proposed, however I plan to submit two separate PRs to replace this one:

• one with the unit testing additions based on the current development branch to validate the unit tests against the current code base
• a second one with the script changes based on the unit test PR branch so that we can validate the script changes against the unit tests.

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

[dsbibby]

/remove-lifecycle stale

[github-actions[bot]]

This Pull Request is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Mark as fresh by adding the comment /remove-lifecycle stale.

[github-actions[bot]]

Closing pull request due to inactivity. Please reopen if needed