ng-clarity icon indicating copy to clipboard operation
ng-clarity copied to clipboard

feat(combobox): add ability to group options

Open kevinbuhmann opened this issue 1 year ago • 4 comments

Disclaimer

  • This feature has not been reviewed for accessibility.
  • This is just me proposing a possible feature. It might never be released.

PR Checklist

  • [ ] Tests for the changes have been added (for bug fixes / features)
  • [ ] Docs have been added / updated (for bug fixes / features)
  • [ ] If applicable, have a visual design approval

PR Type

Feature

What is the current behavior?

The combobox does not a built-in way to group options. Attempts to do this on the "consumer" side are hacky and and not fully accessible.

Issue Number: #635

What is the new behavior?

The combobox allows grouping options.

I used this example as guide: https://www.w3.org/WAI/ARIA/apg/patterns/listbox/examples/listbox-grouped/

Does this PR introduce a breaking change?

No.

kevinbuhmann avatar Apr 14 '23 17:04 kevinbuhmann

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

github-actions[bot] avatar Apr 14 '23 17:04 github-actions[bot]

This PR introduces visual changes: 73e844db457b5229dc813195358b8b3bb71f88a2 If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout kevin/combobox-grouped-options
git fetch https://github.com/vmware-clarity/ng-clarity.git 73e844db457b5229dc813195358b8b3bb71f88a2
git cherry-pick 73e844db457b5229dc813195358b8b3bb71f88a2
git push

github-actions[bot] avatar Apr 14 '23 17:04 github-actions[bot]

Any update on this pull request merge?

kumar-tadepalli avatar May 04 '23 03:05 kumar-tadepalli

Could this be prioritized for next minor version release?

kumar-tadepalli avatar Jun 06 '23 09:06 kumar-tadepalli