wardroom icon indicating copy to clipboard operation
wardroom copied to clipboard

Add support for containerd-based images

Open detiber opened this issue 7 years ago • 6 comments

Currently wardroom bakes images that use docker, we should add the ability to generate images that use containerd instead.

detiber avatar Aug 22 '18 14:08 detiber

This is being worked on here https://github.com/kubernetes-sigs/cluster-api-provider-aws/pull/25 and can be ported here after testing.

vincepri avatar Aug 29 '18 16:08 vincepri

I know that @vincepri said there's some work happening in cluster-api, but I have a branch I can submit as a PR (based on Vince's work) if we'd like to go ahead and close this out.

scottslowe avatar Sep 21 '18 14:09 scottslowe

@scottslowe that would be great, we just haven't had the time to verify the containerd changes do not break the swizzle workflows yet :)

detiber avatar Sep 21 '18 14:09 detiber

@detiber I haven't tested the swizzle workflows, either. I think @craigtracey may have some changes for the swizzle workflows that he has yet to check in. I'll check with him on the status of those changes so that we can see if we should test now or wait for his changes.

scottslowe avatar Sep 21 '18 15:09 scottslowe

Why do we have the same code in multiple repos and copy/paste between them? Can't we standardize on Wardroom?

stevesloka avatar Sep 21 '18 15:09 stevesloka

@stevesloka long term we'd like to standardize the image baking and contribute upstream. Currently we contributed that for cluster-api-provider-aws, but the plan is to try and make it more generally available for the cluster-api.

The main issue with standardizing on Wardroom has been that the scope of this repo has grown beyond just image baking and testing/validating that changes do not break the existing workflows for those additional uses is difficult (such as these containerd changes, which impact the swizzle workflows).

detiber avatar Sep 21 '18 17:09 detiber