pyvcloud icon indicating copy to clipboard operation
pyvcloud copied to clipboard

Add method delete_all_nics to vm.py

Open dwettstein opened this issue 3 years ago • 3 comments

This PR adds the method delete_all_nics to vm.py. The logic is basically the same as in the delete_nic method, except that instead of deleting just the NIC with given index, it deletes all.

NOTE: I have not added a dedicated test for this method, because of the same reason as above.

PS: I recommend to merge also PR #720, as it contains some bugfixes for delete_nic method.


This change is Reviewable

dwettstein avatar Dec 15 '21 20:12 dwettstein

@dwettstein, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

vmwclabot avatar Dec 15 '21 20:12 vmwclabot

@dwettstein, VMware has approved your signed contributor license agreement.

vmwclabot avatar Dec 16 '21 17:12 vmwclabot

Hi @rocknes

I have implemented your requested changes. Is there something left to do for this PR?

Thanks.

dwettstein avatar Jun 20 '22 10:06 dwettstein