pyvcloud icon indicating copy to clipboard operation
pyvcloud copied to clipboard

Stop pyvcloud creating an empty log file called 'vcd_sdk.log'

Open andrew-lee-1089 opened this issue 3 years ago • 3 comments

Remove the need to call "Get_logger" which inadvertently creates an empty vcd_sdk.log file in your current working directory, which seems un-useful for a single log across the whole project.

pyvcloud is great -but there is no logging, I think that is basically fine so long as we are consistent with that fact, implementing logging for one log feels like the worst of both worlds, and is leaving us with an empty file in our current working directory, with no way to configure this log file name or location. I rejected the idea of doing anything fancier here, because sorting out logging in this project felt too big a task for a Tuesday morning.

I've not tested.

Can someone please review?


This change is Reviewable

andrew-lee-1089 avatar Jun 08 '21 08:06 andrew-lee-1089

If I changed it from logger.error to just print - would that be acceptable / not-deemed a non-breaking change?

andrew-lee-1089 avatar Jun 23 '21 08:06 andrew-lee-1089

@rocknes any update on this? I'd like to get this released if possible.

Thanks!

andrew-lee-1089 avatar Oct 17 '22 15:10 andrew-lee-1089

@rocknes , same here. Could we sync path log from client initialzation to this or optional it by path? def _get_default_logger(self, file_name="vcd_pysdk.log",

volehuy1998 avatar Sep 17 '23 11:09 volehuy1998