pyvcloud icon indicating copy to clipboard operation
pyvcloud copied to clipboard

Published 20 hours ago • verified publisher icon vmware-archive

Extended pyvcloud to allow SAML, LDAP integration and general setting…

Open dev-dom opened this issue 5 years ago • 4 comments

Extended pyvcloud to allow SAML, LDAP integration and general settings when creating a ORG

To help us process your pull request efficiently, please include:

  • (Required) Extended system.py to allows user to create org with general settings, ldap and/or SAML

  • (Required) org_params now has a OrgGeneralSettings dictionary that allows to specify the General Settings for org creation (included LDAP and SAML ones)

This change is Reviewable

dev-dom avatar Aug 13 '19 05:08 dev-dom

@dev-dom It's flake8 run is failing. can you please make required changes and also add test case.

kkkothari avatar Aug 14 '19 05:08 kkkothari

@dev-dom It's flake8 run is failing. can you please make required changes and also add test case.

Thanks for your message: I think flake8 is taken care. Will add test case.

dev-dom avatar Aug 22 '19 23:08 dev-dom

Do you format your code with Black?. This project doesn't use Black, and the are some changed lines that don't reflect the intent of this PR.

@dev-dom any reason this PR doesn't merged for such a long time?

azzamsa avatar Sep 22 '20 02:09 azzamsa

This PR needed in main SDK funcionality!

ihumster avatar Apr 07 '21 10:04 ihumster