octant icon indicating copy to clipboard operation
octant copied to clipboard

Updating cronjob to batchv1

Open Freydal opened this issue 3 years ago • 4 comments

What this PR does / why we need it: Fixes an issue with cronjobs being loaded as batch/v1beta1 and the backwards conversion from batch/v1 doesn't work.

Which issue(s) this PR fixes

  • Fixes #2812

Special notes for your reviewer:

Release note:

Updated CronJob marshaled object from batch/v1beta1 to batch/v1

Freydal avatar Jun 02 '22 18:06 Freydal

These NPM failures look similar to some stuff I was seeing locally while toying around. I think a node wizard may need to address it.

Freydal avatar Jun 28 '22 15:06 Freydal

Not a wizard, but the problem is the resolutions field for hosted-git-info in package.json. There’s an open npm-force-resolutions issue where people report sporadic failures with a few different syntaxes. https://github.com/rogeriochaves/npm-force-resolutions/issues/56#issuecomment-1161425697 suggests migrating to the new, builtin overrides field instead so there’s no need for npm-force-resolutions. In this case, npm ls marks both dns-packet and hosted-git-info as ‘extraneous’, so maybe those two entries could be dropped entirely.

Aankhen avatar Jun 29 '22 06:06 Aankhen

@Aankhen I'll look over this shortly, but I went about it differently. #3311

Freydal avatar Jun 29 '22 14:06 Freydal

Hi @Freydal did you have a chance to look into this?

HighWatersDev avatar Aug 25 '22 04:08 HighWatersDev

Quite a pity it wasn't merged yet...

velvetzhero avatar Nov 22 '22 06:11 velvetzhero