Custom Cluster Domains

[clatko]

Is this a BUG REPORT or FEATURE REQUEST?: FEATURE REQUEST

What happened: Cluster Domain hardcoded into NATS/Kafka.

What you expected to happen: To be able to use my custom cluster domain.

How to reproduce it (as minimally and precisely as possible): Set up kafka trigger on a non-cluster.local cluster. Watch it fail.

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version):
• Kubeless version (use kubeless version):
• Cloud provider or physical cluster:

[andresmgot]

Hi @clatko, can you give us more details about the error? How is the domain you are trying to use? The logs of the Kafka/NATS controller should help. I assume the culprit is this piece:

https://github.com/kubeless/kubeless/blob/master/pkg/utils/event_sender.go#L55

The same should happen for CronJobs since they use a similar address.

cc/ @murali-reddy

[murali-reddy]

Agree with @andresmgot. Issue is related to use of cluster.local when using Kubernetes service backing the function pods.

@clatko Just to be sure, you are referring to the custom domain name that can be specified with --cluster-domain?

[clatko]

That is correct. I have a PR to add this as an argument to triggers basically finished. Under a tight deadline so will finish when i can. In the meantime, i just forked and swapped out the hard coded cluster name and rebuilt the kafka trigger controller.

[andresmgot]

thanks @clatko, a PR will be very welcomed

[alexander-alvarez]

:+1: on this. I ran into this issue, but couldn't track it down and then went on vacation. Glad someone was able to find it

[clatko]

i have it finished, just trying to run tests and running into issues on osx. hope to have it done before weekend.

[clatko]

PR here - https://github.com/kubeless/kubeless/pull/857

[mgolovatiy-atconsulting-ru]

https://github.com/kubeless/kafka-trigger/issues/22 The same issue for kafka-trigger