kubecfg icon indicating copy to clipboard operation
kubecfg copied to clipboard

diff subcommand should ignore gc tag

Open kgtw opened this issue 3 years ago • 2 comments

We run the diff subcommand during CI process involved with PR reviews, which comments back the diff as a PR comment in github.

When this happens we are getting false/positives because in some cases the only difference is the gc tag.

"metadata": {
-      "annotations": {
-       "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
-      },
-      "labels": {
-       "kubecfg.ksonnet.io/garbage-collect-tag": "my-service",
-      },

Either the diff subcommand should ignore the gc tag entirely, or the option to provide it should be made available to avoid such instances of this happening.

kgtw avatar Sep 27 '21 10:09 kgtw

which --diff-strategy are you using?

mkmik avatar Sep 27 '21 12:09 mkmik

diff --diff-strategy last-applied

kgtw avatar Sep 27 '21 12:09 kgtw