gcp-pcf-quickstart icon indicating copy to clipboard operation
gcp-pcf-quickstart copied to clipboard

ENV_DIR requires an absolute path

Open zmb3 opened this issue 6 years ago • 1 comments

I ran the script with ENV_DIR=env1 and was greeted with:

~/gcp-pcf-quickstart/src/omg-tf ~/gcp-pcf-quickstart
loading environment config: open env1/config.json: no such file or directory

I am certain that the env1/config.json file exists at this relative path.

If I rerun with ENV_DIR=/Users/me/gcp-pcf-quickstart/env1 everything works.

zmb3 avatar Jun 20 '18 21:06 zmb3

Looks like this happens because the deploy script changes into the ENV_DIR's terraform directory and then runs omg-cli commands.

Might be best just to add a note to the help message and/or README, as checking for relative paths in bash in a portable manner is somewhat nasty.

zmb3 avatar Jun 24 '18 01:06 zmb3