rinku icon indicating copy to clipboard operation
rinku copied to clipboard

JRuby support

Open headius opened this issue 7 years ago • 4 comments

Would you be opposed to including equivalent extension code for JRuby? The port should be pretty straightforward: I have done similar for other small extensions like Psych and the code can be nearly a 1:1 match.

rinku is a direct dependency of Discourse, which we would like to support on JRuby.

headius avatar Feb 23 '18 18:02 headius

I would absolutely not be opposed, this would be a delightful addition.

One thing I should mention is that I lack experience with JRuby itself, so I might need to delegate maintenance (if any — this library is pretty stable) to the community.

If this is fine with you, then by all means!

kivikakk avatar Feb 26 '18 05:02 kivikakk

That seems reasonable to me. I will start a port on a fork and we'll see if we can bang this out!

headius avatar Feb 26 '18 16:02 headius

I started doing a port, but then realized it may be easier to wrap an existing library and just make it match rinku's API. So I started that process here: https://github.com/robinst/autolink-java/issues/20

The autolink-java library says in its README that it is "inspired by rinku" so I'm hoping the mapping will be pretty close.

headius avatar Feb 26 '18 18:02 headius

:+1: Neat! Let me know how that goes/if I can give any more assistance on this side!

kivikakk avatar Feb 27 '18 00:02 kivikakk