houdini icon indicating copy to clipboard operation
houdini copied to clipboard

Unroll MIN as the straight ?: construct

Open yanick opened this issue 12 years ago • 4 comments

Considering that not all compilers give us MIN implicitly, and since it's only at one place in the code, losing the MIN shouldn't be too high a price to pay, readability-wise, for portability.

yanick avatar May 26 '13 22:05 yanick

Just out of curiosity, which common compiler's don't give us MIN? I've been reading through the code in this repo and your PR sparked my interest. Thanks in advance!

christianbundy avatar Dec 02 '13 22:12 christianbundy

Look at the failures of Escape::Houdini 0.1.2 (my Perl wrapper for the houdini lib) at http://www.cpantesters.org/distro/E/Escape-Houdini.html As usual, it's the windows compiler that seems to be causing problems, the naughty git. :-)

yanick avatar Dec 03 '13 02:12 yanick

Thanks for the explanation! I'm going to maintain an updated fork of @vmg's project over at christianbundy/houdini, and I've merged your commit.

christianbundy avatar Dec 03 '13 09:12 christianbundy

Sweet. The Perl module was using my own fork. I'm glad to ear I'll be able to just point to yours and have one less repo to worry about. :-)

yanick avatar Dec 04 '13 00:12 yanick