Vadim Markovtsev comments

Results 288 comments of


                                            Vadim Markovtsev

Not define the name of the application via DSN "application_name=my_app_name"

Hi! Easy-peasy. https://github.com/encode/databases/blob/master/databases/backends/postgres.py#L43 The workaround is to `Database(dsn, **kwargs)` and `dsn.rsplit("&?")`.

Backends crash when the user selects duplicate columns

~~It doesn't affect at least the asyncpg backend. I am not changing the description, sorry.~~ :facepalm: It doesn't affect asyncpg backend in my company's fork. Indeed, I see that the...

RepresenterError while writing a sample file

I can reproduce it neither now... Most likely this is a weird glitch in my environment. Closing. I will reopen if we get this error again.

Linter integration on PRs

We are using flake8 with some deep customization for Python.

Update 13-inch MacBook Pro in Available Hardware

@marnovo Conflict here

[WIP] a proposal to document all datasets and models

This is to notify that I am here and struggling to find the time for a proper review. ETA is Friday.

[WIP] a proposal to document all datasets and models

Damn I am squeezed but will do my best to review ASAP, sorry

[WIP] a proposal to document all datasets and models

Yes, this better explains my rationale, thanks Eiso. I really love this graph BTW, and additional :heart: for using Graphviz to plot it.

[WIP] a proposal to document all datasets and models

I would go with a DD ([template](https://docs.google.com/document/d/1NtbOeUt9mAm3vnseCuEwBvuOI4emSzv0QopvaMYKWU4)). It is easier to discuss and fight, also this change would require actions from ML team or even Apps, depending on our depth...

[WIP] a proposal to document all datasets and models

I am back to this, finally. Reading and editing the document.