Valentin Marchaud

Results 148 comments of Valentin Marchaud

> Is it needed only for our tests or also for production? Apparently for tests only but i didn't test it yet

Added a simple test that patches a esm module and verify that we get the patched version, however making it work with our typescript tooling was pretty much a nightmare....

I've fixed the tests (sorry for the bash hack, i didn't see another way to not run those tests for node < 12) and added a comment in the readme...

> Have you tried running any contrib package against this? Well i believe most of our instrumentation target cjs module so i didn't try, do you have one in mind...

FYI @JamieDanielson offered to move this PR forward in slack's dm (as i find it quite hard to commit time on otel those days, it seems that it might go...

All that activity over #1946 motivated me to take some time from my holiday to get back to this. Good news actually some of the issues i've had has been...

> Thank you for taking time of your holiday working on this. Let me know, how I can help. I think that agitated is a popular ESM package that could...

> We can also use BigInt which is supported in major browsers and node since 10.5 I'm not sure if its related but we had an issue to support int64...

> I'd suggest introducing a series of APIs explicitly involved with the bigints, like meter.createBigIntCounter. Generally other languages have dedicated method for each type so i would be in favor...

I wonder which one would be preferable for for platform that doesn't support bigint ? specially old browser version or edge platform that use old engines ? I personally prefer...