Valentin Marchaud

Results 148 comments of Valentin Marchaud

For context this was discussed in https://github.com/open-telemetry/opentelemetry-js/issues/2104

I'm not sure, its quite tricky to handle because context loss can happen within `with` callback (simply with async/await) so is it worth to change this behavior ? I think...

I'll move this into the API repo (https://github.com/open-telemetry/opentelemetry-js-api/blob/main/src/trace/span.ts#L128)

For reference, we made those utils at my company: ```ts import * as otelAPI from '@opentelemetry/api' import * as otelCore from '@opentelemetry/core' export function withSpan ReturnType> (span: otelAPI.Span, fn: T):...

If i'm not mistaken this is mostly to propagate the correct info across process boundary, even though the span shouldn't noop doesn't mean it isn't part of a bigger trace

I'm fine with that, i would say that it may be worth to add it into the lerna project but in a dedicated top-level directory to make a difference with...

> What work is needed to consider these instrumentations stable? The main problem for me would be to consider `opentelemetry-instrumentation` stable which would means this API is stable for people...

Something i forgot but there also the meaning of an instrumentation stability, does that means the telemetry generated is stable and will not change ? Which sound complex to support...

> Can you provide some info on why this sounds complex? I explained why `opentelemetry-instrumentation` can't become stable IMO, i don't have anything against document-load/xhr/fetch in themselves apart from the...

I think the main thing that will be missing for correct deno support is a correct context manager, the zone start to fail as soon as you use async/await (in...