forcolormap icon indicating copy to clipboard operation
forcolormap copied to clipboard

Compatibility issues with nvfortran

Open gha3mi opened this issue 1 year ago • 1 comments

Hi @vmagnin

I've identified the issue with the nvfortran compiler and reported a simple example on the nvidia compiler forum: https://forums.developer.nvidia.com/t/nvfortran-f-0000-internal-compiler-error-module-new-dtype-dt-nfd/292240

The following changes will resolve the issue and ensure that ForColormap is compatible with nvfortran. I hope that the issue will be resolved soon, but until then, it would be great to consider these changes:


https://github.com/vmagnin/forcolormap/blob/756be0fb29a8784f3d6d4eb9d7776fb46df9aaa8/src/colormap_class.f90#L40

to

character(*), dimension(6+222+4), public, parameter :: colormaps_list = &


https://github.com/vmagnin/forcolormap/blob/756be0fb29a8784f3d6d4eb9d7776fb46df9aaa8/src/miscellaneous_colormaps.f90#L35

to

character(*), dimension(6), parameter, public :: miscellaneous_colormaps_list = &


https://github.com/vmagnin/forcolormap/blob/756be0fb29a8784f3d6d4eb9d7776fb46df9aaa8/src/miscellaneous_colormaps.f90#L35

to

character(*), dimension(222), parameter, public :: scientific_colour_maps_list = &


https://github.com/vmagnin/forcolormap/blob/756be0fb29a8784f3d6d4eb9d7776fb46df9aaa8/src/matplotlib_colormaps.f90#L38

to

character(*), dimension(4), parameter, public :: matplotlib_colormaps_list = &

gha3mi avatar May 08 '24 22:05 gha3mi

Thanks @gha3mi, I have committed those fixes: https://github.com/vmagnin/forcolormap/commit/b7e61546fcc300c31137d451a6222c4ae82e0850 We can let the issue open to revert these changes latter. The 2nd and 4th are not really annoying, but the two with 222 are more annoying if we add more colourmaps and forget to update these numbers.

vmagnin avatar May 09 '24 08:05 vmagnin