Vladimir Sitnikov

Results 969 comments of Vladimir Sitnikov

For reference, here's another case for adding the clarification messages to the failures: * https://github.com/pgjdbc/pgjdbc/blob/efd36c3f9097f7ee4d7c6f68c83d44e6e16be172/pgjdbc/src/test/java/org/postgresql/test/jdbc2/AutoRollbackTestSuite.java#L300-L315 * https://github.com/pgjdbc/pgjdbc/blob/efd36c3f9097f7ee4d7c6f68c83d44e6e16be172/pgjdbc/src/test/java/org/postgresql/test/jdbc2/BatchFailureTest.java#L213-L233

>Is your example here https://github.com/robstoll/atrium/issues/1332#issuecomment-1434572814 also available in a public repository? Not really :-/ Here's how I migrated it to Atrium. I don't quite like the reporting yet, however, it...

>What's the reason that you don't use because but always group? The current `because` has two issues for me: 1) It breaks the mind flow. It sounds weird, and it...

That is fair. I probably need to rename `expectSoftly` to `group`, then it would be extremely consistent :) However, having because inside `toEqual` would look a much better place for...

>I guess you made some copy&paste mistake as the overall_info action's started_when should be the same as session's created_when is repeated 3 times Thanks. They should be removed.

> usage of # as group bullet point? It looks good. >the possibility to use features on the right hand side of an expectation via the using approach? It looks...

Initially I created `toBeWithin` / `toEqualWithErrorTolerance` in the same way ```kotlin expect(x).because(""bla bla bla"){ toBeGreaterThan(5) toBeLessThan(10) } ``` However, it produced bad reports: it does not print print expectations that...

For reference, I've added the compiler plugin `id("io.github.vlsi.kotlin-argument-expression") version "1.0.2"` to my test code, and I have the following results: ```kotlin group({ "overall info action_uid=hextoraw('$overallUid')" }) { expect(rs.getObject("overall_info_started")) .toEqualWithErrorTolerance( rs.getObject("session_created")...

Here's a relevant review by Truth team: https://github.com/google/truth/issues/849

Are there generic ways to add hints or should I try treating `.toEqual` explicitly? I'm interested in fixing diff first as it impacts me more than crlf