Vladimir Sitnikov

Results 969 comments of Vladimir Sitnikov

@bokken , I've resurrected the PR. I think it should be good to merge now. Any thoughts, comments?

Closing as I guess this PR is no longer relevant after https://github.com/pgjdbc/pgjdbc/pull/3044

Another case for composite matchers is `Matcher.or`, `Matcher.and`. For instance: ```kotlin 12 shouldBe (between(0, 2) or between(0, 3)) ``` => ``` java.lang.AssertionError: 12 should be between (0, 3) ``` The...

Here's another candidate for composite matcher API are: https://github.com/kotest/kotest/blob/aba6984d6a08530e931274f7a9f6e3b62a66b681/kotest-assertions/kotest-assertions-shared/src/commonMain/kotlin/io/kotest/assertions/eq/RegexEq.kt#L12-L16 https://github.com/kotest/kotest/blob/0ba14983d485b1b1caef0e5a2cd7402ba47e34d2/kotest-assertions/kotest-assertions-core/src/commonMain/kotlin/io/kotest/matchers/regex/RegexMatchers.kt#L24-L34 They implement pretty much the same thing, however, `regex shouldBe regex` fails with a bad message since it misses both...

@pientaa , data class matcher have no use for me. I have provided a sample of what I need: composing and comparing results from multiple databases. Data class matchers have...

@pientaa , I appreciate your time on improving the naming (it does matter), however, I am pretty sure `Matcher.compose` targets only a small subset of cases (no matter the naming),...

>I proposed more flexible way of composing matchers here https://github.com/kotest/kotest/pull/3406 Frankly speaking, I do not see why you propose "more flexible way of composing matchers" in "Rename Data Class Matchers...

> What do you think about an easy fix like that? Of course it is much better output than the current implementation of and/or, however, I am not interested in...

> first.passed() && second.passed() However, please note that this change significantly alters the behaviour. You basically kill short-circuit feature(previously the second matcher was not executed if the first failed), so...

>I thought about your request for a while and it looks like we don't need to add builder to achieve what you want to achieve > I was able to...