Vladimir Sitnikov

Results 969 comments of Vladimir Sitnikov

I think this is mergeable. Of course, we might adjust oids used for testing, on the other hand, I doubt they will induce issues in the future.

We should definitely test and document cases when rewrite is not activated

I'm inclined to add `pgjdbc-jfrunit` subproject with https://github.com/moditect/jfrunit tests. That would be executed with Java 17+ only, however, it would enable us to assert on the number of network roundtrips,...

Is there a query to measure the number of network roundtrips and bytes sent/received?

@mmimica do you think you could add tests that would cover the following? a) ensure the rewrite did happen (e.g. via `statement_timestamp`) b) ensure the rewrite does not happen for...

I've rebased the PR, however, I have not reviewed the code and tests yet.

That is a good point. If we support named parameters for `PreparedStatement`, then it is probably worth supporting them for `CallableStatement` as well.

There's a PR: https://github.com/pgjdbc/pgjdbc/pull/1946 I guess it would support `CallableStatement` thanks to `CallableStatement extends PreparedStatement`.

The feature has been implemented in https://github.com/pgjdbc/pgjdbc/pull/2483

Sorry it took years to merge, however, I believe now we are getting really close. I close this PR in favour of https://github.com/pgjdbc/pgjdbc/pull/2852 which will likely get merged soon.