Vladimir Sitnikov

Results 969 comments of Vladimir Sitnikov

@FSchumacher , can you please clarify what behavior you want to achieve before adding `dst-like` code? In 99.42% of the cases, `dstOffset` code is invalid, and it should be avoided.

> if you have a better version that works What do you mean by `works` ? What is the intended behavior when "adding 1 day"? Do you intend it always...

>Where do you read from the code, that I add 1 day or 24 hours? Ok. `TimeShift` function is using `java.time.Duration`, thus it always treats "day" unit as 24 hours...

Am I right the suggested shortcut is `ctrl+alt+f` to reset the search? Does it come from a standard? Have you considered using `esc` shortcut to reset the search?

Frankly speaking, I think we should try using `ESC` shortcut for "resetting the search"

I did try to review this, and my conclusion is as follows: 1) I would like to decline the patch, as adding more and more stuff to JMeter's SSL makes...

We could probably use WireMock for testing: http://wiremock.org/docs/https/

> It can be removed, as a class, but all the logic of handling alias selection is still needed, and will have to be moved to JsseSSLManager I guess the...

> Ah, are you suggesting to, instead of using a singleton SSL manager A bit of a story is that currently JMeter relies on Java's default keystore properties, and Java...