Vladimir Sitnikov
Vladimir Sitnikov
@jensim , hi, it is great you implemented a limiter, however, have you considered https://github.com/bucket4j/bucket4j? It looks like they have well-thought API, and they cover many cases like bursts, etc.
@qwwdfsad , I'm not sure what is your view, however, I just asked what bucket4j maintaners think of writing the core in Kotlin.
@jensim , my idea was to convince bucket4j to move to Kotlin, so bucket4j automatically becomes available on all the platforms. In that regard, "minimal impl" does not sound to...
>cannot avoid standard library dependency anyway (e.g. the kotlinc puts enhanced null-checks on arguments of all public methods, and these checks are located in stdlib). Fair point. I missed that...
For now, I am interested in `ByteSourceTester` and `ByteSinkTester` for testing https://github.com/pgjdbc/pgjdbc/pull/2376
It looks like the version order is not consistent, so the better approach would be sorting the versions. Here's how Maven sorts versions: https://github.com/gradle/gradle/issues/11760#issuecomment-569244112 Unfortunately, Gradle has slightly different rules...
Just in case: I mean **public** bits of the keys :)
Here's CI log in my fork: https://github.com/vlsi/assertj-core/runs/6645822760?check_suite_focus=true#step:5:46
Of course, I don't suggest enabling and fixing all the bug patterns, however, I believe the errors produced by the default configuration should be fixed. Even some of the "warnings...
@joel-costigliola , one more question: for now, I include `errorprone` Maven plugin right into `assertj-core`, however, you might want to add it to the base configuration (https://github.com/assertj/assertj-parent-pom ?) In my...