Vladimir Sitnikov

Results 1160 comments of Vladimir Sitnikov

Well, in theory, `asSet()` is used only in deprecated method `org.postgresql.core.QueryExecutor#getBinaryReceiveOids` that is never used within the driver's code. I guess we can make it less efficient, so we could...

> so we limit the max OID stored in a BitSet with 8192*8, It means we store small values in `BitSet` and large values (if any) in `HashSet`.

I fully understand your intention, and I appreciate the roadmap. However, what do you think of releasing one of the upcoming versions as 1.0.0, and implement "all your 1.0 plans...

@mipo256 , do you think if adding a test like in https://github.com/pgjdbc/pgjdbc/issues/621#issuecomment-1148258959 makes sense? In other words, what if we create two procedures like `my_procedure(int4, int4)` and `my_procedure(varchar, varchar)`, set...

@sehrope , I remove `ChannelBindingRequiredTest` here as `SslTest` verifies many more cases. I hope you don't mind.

>run all of nothing. It takes about 20-50 seconds on my machine. I find it acceptable. What do you expect by "test one slice of functionality"? If you mean "test...

I think this is mergeable: the tests pass, the missing assertions added, the bug with clientcert in PG11 fixed. I've created https://github.com/pgjdbc/pgjdbc/pull/3681 to configure TLS in Appveyor

This is a nice idea, however, the ASF retires the feather logo, so I would suggest postpone the icon till the new logo establishes. See https://opensourcewatch.beehiiv.com/p/apache-software-foundation-retiring-feather-logo

> Add PGProperty.PREFER_QUERY_MODE.set(props, "simple"); to your code and it works fine. I would treat simple query mode as a workaround only, and I would refrain from recommending "simple" by default....