Vladimir Sitnikov

Results 1168 comments of Vladimir Sitnikov

By the way, I am not against adding validation for non-official url/sha. However, I am leaning towards that adding such a support should probably come as a different issue/PR. For...

>There is no "extra" functionality for custom distributions - the action can't validate those, so it should simply skip them. Imagine the project uses the official Gradle distribution + sha....

> As said above, I wonder what the signal/noise ratio would be given the line endings potential problem and the fact it is intended that people modify it if they...

@MaxMello , thanks for the reproducer. Thank you a lot. It would definitely be great to integrate those steps into our test suite. It might be executing all the tests...

Yeah, it looks like we should use `current_database()` rather than get database name from the url

At the same time, it looks like the database could report `database name` when client connects to the db. I mean it would be great if the database name was...

> It is not obvious to me anyway to do a rewrite and provide a valid api response. Something like "rows [0..10) resulted in 10 modifications, rows [10..20) resulted in...

Thank you for the draft, and sorry for the delay with the review. In general, it looks like a good start. However, it looks like `GlobalHostStatusTracker` duplicates the logic of...

> If the server closes an HTTP connection, jmeter should handle the closed connection immediately and not keeping it in CLOSE_WAIT state until the next request, which could also lead...

> because this means the server is trying to shut down the socket, but the client didn't do it yet First, if the server was about to close the connection...