Vladimir

Results 128 comments of Vladimir

Instead of replacing `"$OSTYPE" == "linux-gnu"` with `"$OSTYPE" == "linux"*` (a few characters change) the suggestion is to invoke the compiler to do nothing just to see if it will...

@jmitrevs Only if we split the build script over vivado/vitis (vivado compiler will say c++14 doesn't exist)

@nghielme It is still marked as a draft, so no one took the time to thoroughly review it :wink:. Also, it will come after 1.0.0

The only thing I see lacking here is the use of function pointers for depnse instead of the current `if (strategy == latency) do_latency_dense() else do_resource_dense()` approach. We moved the...

This is now ready. Let's just wait to see if I messed up the tests before we merge.

I think it would be good to have a full test, but until we improve the synthesis testing pipeline, maybe mark it with `@pytest.mark.skip(reason='Skipping synthesis tests for now')`. This way...

This looks good and ready to be merged. One change I made (which I think is long overdue) is to ensure multiple iterations of the top function are called when...

I think this is fixed by #997. The model however is too large for hls4ml and won't work.

Probably a conversion error somewhere and the HLS model is not properly connected. The synthesis log will have plenty of warnings I assume

First in line on my PR review TODO list, I expect early next week to have time for this.