vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[Bugfix] Update grafana dashboard

Open zhan9san opened this issue 1 year ago • 4 comments

Use templated datasource in query

FIX #6136 It defines a variable DS_PROMETHEUS. It should be used in the variable model_name but it does not.

Q: Why the metric vllm:num_requests_running is introduced? A: The label model_name is too common that node_exporter will also set this label to metrics. With a specific metric, it can ensure the metrics is vllm-related

Here is a negative example. See model_name="45N1767" in node_power_supply_info.

node_power_supply_info{capacity_level="Normal", env="build", exported_type="Battery", instance="example.com:9100", job="k8s", manufacturer="SANYO", model_name="45N1767", power_supply="BAT0", serial_number="3861", status="Not charging", team="build", technology="Li-ion", type="k8s"}

zhan9san avatar Oct 12 '24 08:10 zhan9san

👋 Hi! Thank you for contributing to the vLLM project. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

github-actions[bot] avatar Oct 12 '24 08:10 github-actions[bot]

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

github-actions[bot] avatar Feb 25 '25 02:02 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @zhan9san.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Feb 25 '25 02:02 mergify[bot]

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

github-actions[bot] avatar May 27 '25 02:05 github-actions[bot]