vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[CI/Build] Update pixtral tests to use JSON

Open DarkLight1337 opened this issue 1 year ago • 5 comments

I can verify that the Pixtral tests after #8415 pass on my L40. However having pickle files in the repo may be flagged as a security risk, so I'm changing them to JSON in this PR.

cc @patrickvonplaten

DarkLight1337 avatar Sep 13 '24 01:09 DarkLight1337

👋 Hi! Thank you for contributing to the vLLM project. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

github-actions[bot] avatar Sep 13 '24 01:09 github-actions[bot]

Do you want to remove the skip decorator and see if it actually passes on our CI?

ywang96 avatar Sep 13 '24 01:09 ywang96

Even the smallest test takes up 40 GB VRAM so it will cause OOM in CI.

DarkLight1337 avatar Sep 13 '24 01:09 DarkLight1337

We probably have to split the model using TP if we want to run the tests in CI.

DarkLight1337 avatar Sep 13 '24 01:09 DarkLight1337

Let’s skip the TP addition for a later PR then

ywang96 avatar Sep 13 '24 01:09 ywang96

Thanks a lot @DarkLight1337 - make sense pickle is not the best format

patrickvonplaten avatar Sep 13 '24 08:09 patrickvonplaten