vllm icon indicating copy to clipboard operation
vllm copied to clipboard

CMake warning: Show unsupported CUDA version instead of Python version

Open janimo opened this issue 1 year ago • 1 comments

When changing CUDA_SUPPORTED_ARCHS CMake prints messages of the form

discarding unsupported CUDA arch 3.10

where instead of the cuda arch it shows the Python version

janimo avatar Sep 12 '24 12:09 janimo

👋 Hi! Thank you for contributing to the vLLM project. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

github-actions[bot] avatar Sep 12 '24 12:09 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @janimo.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Nov 07 '24 17:11 mergify[bot]

@janimo would you mind rebasing this and resolving the conflict?

russellb avatar Nov 07 '24 17:11 russellb

@russellb the code seems to have been reorganized/removed so the patch is no longer relevant.

janimo avatar Nov 07 '24 17:11 janimo

@russellb the code seems to have been reorganized/removed so the patch is no longer relevant.

Ah, sure enough. Thanks for taking a look. I'll close this out.

russellb avatar Nov 07 '24 19:11 russellb