vllm
vllm copied to clipboard
[Model] Support multiple images for qwen-vl
This PR finishes exposing multi-image support for Qwen-VL (not Qwen2) as follow-up to https://github.com/vllm-project/vllm/pull/8029.
Multi-image offline inference example (.generate)
from vllm import LLM, SamplingParams
from vllm.multimodal.utils import fetch_image
question = "Can you compare these images?"
image_urls = [
"https://upload.wikimedia.org/wikipedia/commons/d/da/2015_Kaczka_krzy%C5%BCowka_w_wodzie_%28samiec%29.jpg",
"https://upload.wikimedia.org/wikipedia/commons/7/77/002_The_lion_king_Snyggve_in_the_Serengeti_National_Park_Photo_by_Giles_Laurent.jpg",
]
llm = LLM(
model="Qwen/Qwen-VL-Chat",
trust_remote_code=True,
limit_mm_per_prompt={"image": len(image_urls)},
dtype="half"
)
get_img_prompt = lambda img_num: f"Picture {img_num}: <img></img>\n"
placeholders = "".join(get_img_prompt(i) for i, _ in enumerate(image_urls, start=1))
prompt = f"<|im_start|>user\n{placeholders}{question}\n<|im_end|>\n<|im_start|>assistant\n"
sampling_params = SamplingParams(temperature=0.2, max_tokens=64)
outputs = llm.generate({
"prompt": prompt,
"multi_modal_data": {
"image": [fetch_image(url) for url in image_urls]
},
},
sampling_params=sampling_params
)
for o in outputs:
generated_text = o.outputs[0].text
print(generated_text)
The two images shown are different. The first image is of a male mallard duck swimming in a body of water, while the second image is of a male lion resting in the tall grass. The two images are unrelated and cannot be compared.<|im_end|>
Chat example:
Image numbering is already handled properly in the chat utils, so no extra changes needed there.
Server:
python -m vllm.entrypoints.openai.api_server \
--device cuda \
--model Qwen/Qwen-VL-Chat \
--api-key token-abc123 \
--chat-template examples/template_chatml.jinja \
--tokenizer Qwen/Qwen-VL-Chat \
--dtype=half \
--limit-mm-per-prompt image=2 \
--trust-remote-code &
Client:
from openai import OpenAI
client = OpenAI(base_url="http://localhost:8000/v1", api_key="token-abc123")
completion = client.chat.completions.create(
model="Qwen/Qwen-VL-Chat",
messages=[
{
"role": "user", "content": [
{"type": "image_url", "image_url": {"url": "https://upload.wikimedia.org/wikipedia/commons/d/da/2015_Kaczka_krzy%C5%BCowka_w_wodzie_%28samiec%29.jpg"}},
{"type": "image_url", "image_url": {"url": "https://upload.wikimedia.org/wikipedia/commons/7/77/002_The_lion_king_Snyggve_in_the_Serengeti_National_Park_Photo_by_Giles_Laurent.jpg"}},
{"type": "text", "text": "Can you compare these images?"},
]
}
]
)
print(completion.choices[0].message)
ChatCompletionMessage(content='The images shown are different and cannot be compared. Image 1 is a duck swimming in water, and Image 2 is a lion lying in the grass. They are completely different in both content and subject.<|im_end|>\n', refusal=None, role='assistant', function_call=None, tool_calls=[])
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.
Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
- We adhere to Google Python style guide and Google C++ style guide.
- Pass all linter checks. Please use
format.sh
to format your code. - The code need to be well-documented to ensure future contributors can easily understand the code.
- Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
- Please add documentation to
docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.
Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required
and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
- After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
- After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
- After the review, the reviewer will put an
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR. - Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.
Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!