[CI/Build] upgrade Dockerfile to ubuntu 22.04
Upgrade the Dockerfile to use Ubuntu 22.04 instead of 20.04. The current image has and old version of curl which is missing the --fail-with-body flag and also has several high vulnerabilities:
CVE-2023-52433
HIGH
linux-libc-dev
5.4.0-189.209
-
CVE-2023-0461
HIGH
linux-libc-dev
5.4.0-189.209
-
CVE-2024-27397
HIGH
linux-libc-dev
5.4.0-189.209
-
CVE-2023-21400
HIGH
linux-libc-dev
5.4.0-189.209
-
CVE-2024-26921
HIGH
linux-libc-dev
5.4.0-189.209
-
CVE-2023-20569
HIGH
linux-libc-dev
5.4.0-189.209
-
CVE-2024-26800
HIGH
linux-libc-dev
5.4.0-189.209
-
FIX #7106 BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Model]for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]For changes on the vLLM frontend (e.g., OpenAI API server,LLMclass, etc.)[Kernel]for changes affecting CUDA kernels or other compute kernels.[Core]for changes in the core vLLM logic (e.g.,LLMEngine,AsyncLLMEngine,Scheduler, etc.)[Hardware][Vendor]for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]).[Misc]for PRs that do not fit the above categories. Please use this sparingly.
Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
- We adhere to Google Python style guide and Google C++ style guide.
- Pass all linter checks. Please use
format.shto format your code. - The code need to be well-documented to ensure future contributors can easily understand the code.
- Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
- Please add documentation to
docs/source/if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.
Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.
What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
- After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
- After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
- After the review, the reviewer will put an
action-requiredlabel on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR. - Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.
Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!
👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.
Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).
To run full CI, you can do one of these:
- Comment
/readyon the PR - Add
readylabel to the PR - Enable auto-merge.
🚀
We had to use Ubuntu 20 because of compatibility reason for wheel build. However, I believe it is possible to use 20 to build and 22 to test and openai server.
Thanks! That's very helpful to know. I will try and do a build to see if the compatibility issue is still there. Ideally both build and openai image use 22.04 to keep things consistent, however, happy to do what you suggested instead too.
When will we be seeing vLLM on docker with ubuntu base image 22.04 LTS which will make it more adaptable for production grade systems.
@samos123 were you able to build the image locally, with 22 LTS for openai server? I am running into this error even when building in local.
https://github.com/vllm-project/vllm/issues/7401
My laptop crapped out during local builds for some reason. I will try to pick this up by spinning up a cloud VM to do builds.
Yes it will need a gpu vm to build
The github action CI job runs out of disk space lol. We should optimize the Docker image so they're smaller.