vllm
vllm copied to clipboard
[Doc] Update description of vLLM support for CPUs
Hi all,
The description of CPU support in vLLM is out of date. It would be better to update it.
Thanks. Best regards, Jie
Hi @mgoin , are you fine with the current change in cpu-installation.rst?
Thanks.
Hi @DamonFool, yes this is fine! It would be nice to make a new section for avx2, but I'll leave that up to you.
Hi @DamonFool, yes this is fine! It would be nice to make a new section for avx2, but I'll leave that up to you.
The patch aims to tell people that AVX512 is not required for vLLM on x86 CPU (and you can also try it on avx2 too).
There seems no difference to build and run vLLM on avx512 and avx2. So I'm not sure what should I add for the avx2 section. Any suggestions? Thanks.
Hi @WoosukKwon , are you OK with this change? Thanks.
Hi @mgoin , @WoosukKwon seems to be busy with other things. Do you think it's fine to get this doc-only change merged regarding that there is no objection from the community? Thanks.
@DamonFool Yes, I am simply waiting for your check to be green. I cannot merge without passing checks. Please try merging with main
Please try merging with main
Done. Thanks.
All the required CI tests had been passed. @mgoin Thanks.
I'm good with this doc change, but a little bit worried about the potential confusion and complexity as the Intel team will be adding IPEX or other intel-cpu-only optimizations to the cpu backend.
I'm good with this doc change, but a little bit worried about the potential confusion and complexity as the Intel team will be adding IPEX or other intel-cpu-only optimizations to the cpu backend.
Thanks @WoosukKwon .
You mean vllm-cpu on intel may run faster than other cpus? Since vLLM can already run on AMD and PowerPC cpus, it would be good to let people know that fact. Then, vLLM would be used more widely. And we can do more opts on other cpus when necessary in the future, right?
@DamonFool Sorry for misleading you. Yes this PR doesn't have a problem. I just wanted to say we'll need to figure out how to efficiently maintain the Intel and non-Intel CPU backends while not complicating the code.
@DamonFool Sorry for misleading you. Yes this PR doesn't have a problem. I just wanted to say we'll need to figure out how to efficiently maintain the Intel and non-Intel CPU backends while not complicating the code.
Got it. Thank you all for the help.