vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Published 20 hours ago • verified publisher icon vllm-project

[Model] LoRA gptbigcode implementation

Open raywanb opened this issue 1 year ago • 4 comments

Added lora adapters to gptbigcode

Resolves #3011

raywanb avatar Apr 09 '24 20:04 raywanb

Thanks, please update the tests!

Done!

raywanb avatar Apr 10 '24 20:04 raywanb

@raywanb great, all that's left is to run ./format.sh to make lint pass

Yard1 avatar Apr 10 '24 21:04 Yard1

@Yard1 it's ready to merge!

raywanb avatar Apr 11 '24 03:04 raywanb

@raywanb could you resolve the conflicts one more time :pray:

njhill avatar May 13 '24 18:05 njhill

@raywanb could you resolve the conflicts one more time 🙏

just did!

raywanb avatar May 20 '24 02:05 raywanb

Thanks @raywanb! Could you please also run the linter on the final changes to fix those errors? (./format.sh)

njhill avatar May 20 '24 15:05 njhill

@raywanb the lora CI test failures also look suspicious, these aren't currently failing on the main branch. cc @Yard1

njhill avatar May 20 '24 16:05 njhill

Yeah those are real failures...

Yard1 avatar May 20 '24 17:05 Yard1

@raywanb thanks for the updates! It looks like the lora tests are still failing though.

There was an issue in the main branch but I don't think that's the cause. Would be good if you could merge in main again once #4944 has been merged and then check the failures..

njhill avatar May 21 '24 15:05 njhill

Yep will look into it later today

raywanb avatar May 21 '24 20:05 raywanb