vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Bump pydantic version from 1.10.13 to >= 1.9.0, < 3

Open kmcleste opened this issue 6 months ago • 1 comments

Updating pydantic version from 1.10.13 to >= 1.9.0, < 3. The version was originally pinned due to a dependency on the OpenAI python library. OpenAI has since updated their version requirements for pydantic. See OpenAI docs for the version change: pyproject.toml.

Pydantic V1 is no longer supported, and suggests migration to V2 (Migration Guide).

kmcleste avatar Jan 03 '24 01:01 kmcleste

bumping this! currently blocking our deployment of vllm, which has to integrate with other pydantic ecosystem packages

looks like you need to format the code @kmcleste to pass checks, yapf -r vllm tests should do the trick

jvmncs avatar Jan 08 '24 19:01 jvmncs

Bumping this as well, as we also need this to support Pydantic 2.x in our integrations.

saattrupdan avatar Jan 10 '24 10:01 saattrupdan

Thank you for your contribution. I will close this in favor of #2531

simon-mo avatar Jan 21 '24 23:01 simon-mo