vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[BugFix] Fix topk_softmax assert

Open ProExpertProg opened this issue 6 months ago • 3 comments

Essential Elements of an Effective PR Description Checklist

  • [x] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [x] The test plan, such as providing test command.
  • [x] The test results, such as pasting the results comparison before and after, or e2e results
  • [ ] (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Fix the assert (only compiled in debug mode) and change it to a TORCH_CHECK. Introduced in #18434.

Test Plan

CI

Test Result

(Optional) Documentation Update

ProExpertProg avatar Jun 17 '25 18:06 ProExpertProg

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Jun 17 '25 18:06 github-actions[bot]

Thanks for the fix @ProExpertProg 🙌

Can you merge from main to see if the CI failures can be resolved?

DarkLight1337 avatar Jun 20 '25 04:06 DarkLight1337