vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[CI][Neuron] Fail and exit on first error

Open elaineyz opened this issue 10 months ago • 2 comments

Essential Elements of an Effective PR Description Checklist

  • [ ] The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • [ ] The test plan, such as providing test command.
  • [ ] The test results, such as pasting the results comparison before and after, or e2e results
  • [ ] (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Update the neuron buildkite script to fail on first errored file. This will prevent errors getting ignored silently.

Test Plan

I first ran the updated bash command locally to make sure all tests are still passing; next I temporarily modified one of the neuron test scripts to raise an arbitrary exception and verified that the command terminates immediately.

Test Result

See above

(Optional) Documentation Update

elaineyz avatar Jun 13 '25 20:06 elaineyz

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Jun 13 '25 20:06 github-actions[bot]

@DarkLight1337 / @simon-mo / @WoosukKwon can you help approve and merge this minor change? thanks!

elaineyz avatar Jun 19 '25 22:06 elaineyz