vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[Core] Add constants for CUDA compute capabilities

Open russellb opened this issue 6 months ago • 6 comments

While looking at this code, I saw the constants 80, 60, etc., in use. The meaning was not familiar to me without looking it up. Create an int type to give symbolic names to each compute capability level, which makes the code a bit easier to read.

Signed-off-by: Russell Bryant [email protected]

russellb avatar Jun 03 '25 17:06 russellb

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Jun 03 '25 17:06 github-actions[bot]

/gemini review

simon-mo avatar Jun 03 '25 18:06 simon-mo

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Jun 05 '25 21:06 mergify[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Jun 09 '25 14:06 mergify[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Jun 11 '25 16:06 mergify[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Jun 19 '25 04:06 mergify[bot]

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

github-actions[bot] avatar Sep 18 '25 02:09 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Sep 21 '25 23:09 mergify[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @russellb.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Sep 22 '25 18:09 mergify[bot]

I don't feel strongly enough about this one to rebase it anymore, so i'll just close it

russellb avatar Nov 20 '25 20:11 russellb