vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Avoid overwriting vllm_compile_cache.py

Open youngkent opened this issue 8 months ago • 1 comments

When vLLM is reusing a previously compile torch.compile cache files, it should not modify/overwrite it, since nothing is expected to be changed under the same hash.

After the change, verified the cache dir is no longer modified when existing cache file is found.

youngkent avatar Apr 29 '25 22:04 youngkent

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Apr 29 '25 22:04 github-actions[bot]