vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[ROCm] Effort to reduce the number of environment variables in command line

Open hongxiayang opened this issue 8 months ago • 2 comments

This is to set two environment variables in the Docker file so that users can reduce the number of environment variables when running scripts.

ENV that can improve safe tensor loading, and end-to-end time

ENV SAFETENSORS_FAST_GPU=1

ENV that needed for multi-process on cuda-like platform

ENV VLLM_WORKER_MULTIPROC_METHOD=spawn

hongxiayang avatar Apr 26 '25 14:04 hongxiayang

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Apr 26 '25 14:04 github-actions[bot]

Can we add a test plan?

houseroad avatar Apr 26 '25 16:04 houseroad

Can we add a test plan?

Added the test plan in the description of the pull request

hongxiayang avatar Apr 27 '25 19:04 hongxiayang