vllm icon indicating copy to clipboard operation
vllm copied to clipboard

Clean up Engine Args & Documentation

Open vincent-4 opened this issue 9 months ago • 1 comments

Early WIP for #14386 There is surely space for improvement WRT argument ordering, I just haven't fully determined the best show things in necessarily

vincent-4 avatar Mar 07 '25 05:03 vincent-4

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Mar 07 '25 05:03 github-actions[bot]

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @vincent-4.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Mar 08 '25 15:03 mergify[bot]

@jpli02 If you want to help out I can give you access to my branch... Feel free to take it in a different direction.. it's generally correct but haven't gotten around to the last mile, and it'd be nice to have this done sooner rather than later less we start to have even more arguments in the engine! (bad.)

👍

vincent-4 avatar Mar 17 '25 02:03 vincent-4

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @vincent-4.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar Mar 27 '25 05:03 mergify[bot]