vllm-project
[wip] scaled_mm_bw_sm100
👋 Hi! Thank you for contributing to the vLLM project.
💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.
Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.
To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.
🚀
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
It looks like scaled_mm_blockwise_sm100_fp8.cu and scaled_mm_blockwise_sm100_fp8_dispatch.cuh were committed only as symlinks. When the change is done and ready for review, make sure to double check the actual files are added.
I'm curious to compare it to the blockwise kernels I wrote in the blackwell-rebase-feb20 branch of deepinfra/vllm , since we had to change the scale factor to be fp8
Thank you @wenscarl! Please correct thecutlass_scaled_mm_supports_block_fp8() function in scaled_mm_entry.cu to allow >100 arch as well.
This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @wenscarl.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Looks good to me now, thank you!
Please merge in latest main to fix the docker-build-image failure
This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @wenscarl.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork