vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[Misc][Docs] fix the comments of KV_T and CACHE_T in CALL_RESHAPE_AND_CACHE_XX macros

Open yangsijia-serena opened this issue 9 months ago • 1 comments

Perhaps I misunderstood something, but I currently think that the comments of KV_T and CACHE_T in the CALL_RESHAPE_AND_CACHE_XX macros are swapped. If my understanding is correct, this PR will fix them.

Please help to review~ Thanks! cc @comaniac @Yard1 @LucasWilkinson

yangsijia-serena avatar Mar 06 '25 09:03 yangsijia-serena

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Mar 06 '25 09:03 github-actions[bot]

Hi @LucasWilkinson, just a gentle ping on this. If I misunderstood anything, please feel free to point it out and close this PR. Thank you!

yangsijia-serena avatar Mar 17 '25 12:03 yangsijia-serena

DCO is not a merge blocker, but the failed tests are. We should be able to force merge this PR given it only changes the comments.

comaniac avatar Mar 18 '25 00:03 comaniac