[V1][Molmo] Fix get_multimodal_embeddings() in molmo.py
Expected: get_multimodal_embeddings() should return list[Tensor] for GPUModelRunner to iterate.
Actual: prior to this PR, molmo's _get_mm_embeds() returns a list thus get_multimodal_embeddings() returns a list of list.
The issue is surfaced when all of following satisfy:
- more than one request
- the tailing part of each request is a bit different, to trigger partial cache hit
This PR also updates vision_language.py to help reproduce above issue.
Tested with:
VLLM_USE_V1=1 \
python examples/offline_inference/vision_language.py \
--model molmo \
--num-prompts=2 \
--use-different-prompt-per-request
cc @DarkLight1337 @ywang96
👋 Hi! Thank you for contributing to the vLLM project.
💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.
Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.
To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.
🚀
This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @lk-chen.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork