vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[Feat][whisper] add more sampling parameters to whisper endpoint

Open joennlae opened this issue 8 months ago • 5 comments

This PR adds the following sampling parameters to the whisper endpoint:

seed, frequency_penalty, repetition_penalty, presence_penalty

joennlae avatar Feb 26 '25 16:02 joennlae

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Feb 26 '25 16:02 github-actions[bot]

Added documentation and updated the example

joennlae avatar Feb 27 '25 10:02 joennlae

Streaming PR landed, would you mind rebasing your work on current main?

NickLucche avatar Mar 06 '25 12:03 NickLucche

any estimate when this might land?

JakubCerven avatar Apr 11 '25 09:04 JakubCerven

I am currently not working on that. As the key feature for us would be beam search implementation. Which is currently in a heavy limbo state due to the migration to V1. Once V1 is a bit more set in stone, I will probably reconsider vllm with a "quick" beam search implementation. So feel free to rebase this again.

joennlae avatar Apr 12 '25 08:04 joennlae

I will rebase this if that's ok with you @joennlae . This might actually be already useful for benchmarking parameters. Thanks for your contribution!

NickLucche avatar Apr 14 '25 08:04 NickLucche

This pull request has merge conflicts that must be resolved before it can be merged. Please rebase the PR, @joennlae.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

mergify[bot] avatar May 29 '25 14:05 mergify[bot]