vllm icon indicating copy to clipboard operation
vllm copied to clipboard

XGRAMMAR now support aarch64

Open johnnynunez opened this issue 9 months ago • 3 comments

This pull request includes updates to the requirements-common.txt file and modifications to the fallback_or_error function in the vllm/model_executor/guided_decoding/__init__.py file. The changes aim to update dependencies and streamline the guided decoding process.

Dependency updates:

  • requirements-common.txt: Updated the xgrammar dependency to version 0.1.14.

Guided decoding improvements:

  • vllm/model_executor/guided_decoding/__init__.py: Removed the fallback logic for non-x86 CPUs and the check for CpuArchEnum.X86 in the fallback_or_error function, simplifying the code and removing unnecessary platform-specific handling.

johnnynunez avatar Feb 26 '25 12:02 johnnynunez

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Feb 26 '25 12:02 github-actions[bot]

@johnnynunez

Could you please update the xgrammar version in requirement to v0.1.14 ? Then I will colse my PR.

Find more details at here.

shen-shanshan avatar Mar 03 '25 08:03 shen-shanshan

@johnnynunez

Could you please update the xgrammar version in requirement to v0.1.14 ? Then I will colse my PR.

Find more details at here.

Done

johnnynunez avatar Mar 03 '25 08:03 johnnynunez

@mgoin when will it be merged?

johnnynunez avatar Mar 09 '25 13:03 johnnynunez

your pre-commit is failing

robertgshaw2-redhat avatar Mar 09 '25 17:03 robertgshaw2-redhat

your pre-commit is failing

done!

johnnynunez avatar Mar 10 '25 12:03 johnnynunez

This will be addressed by #14868

aarnphm avatar Mar 16 '25 14:03 aarnphm