vllm icon indicating copy to clipboard operation
vllm copied to clipboard

[V1][core] Support allowed_token_ids in V1 sampler

Open catherinelee274 opened this issue 10 months ago • 2 comments

Introduce allowed_token_id support in v1 Sampler.

Tested with: pytest tests/v1/sample/test_sampler.py -k "test_sampler_allowed_token_ids"

Fixes #13058

catherinelee274 avatar Feb 18 '25 12:02 catherinelee274

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

github-actions[bot] avatar Feb 18 '25 12:02 github-actions[bot]

Thanks @catherinelee274! There is actually a PR already open for this though: https://github.com/vllm-project/vllm/pull/13210

njhill avatar Feb 18 '25 17:02 njhill

@catherinelee274 Closing this as #13210 is merged. Thanks!

WoosukKwon avatar Feb 22 '25 17:02 WoosukKwon