aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

Increase gateway request timeout from 120s to 1800s

Open varungup90 opened this issue 9 months ago • 1 comments

Pull Request Description

while running benchmark tests I came across scenario where if token length is more than 4k and QPS > 100, I was connection timeout errors. Increasing the timeout from 120s to 1800s. In future we will make these values configurable and users can set per their requirement.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • [ ] PR title includes appropriate prefix(es)
  • [ ] Changes are clearly explained in the PR description
  • [ ] New and existing tests pass successfully
  • [ ] Code adheres to project style and best practices
  • [ ] Documentation updated to reflect changes (if applicable)
  • [ ] Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

varungup90 avatar Mar 18 '25 20:03 varungup90

1800 seems too high. Let's hold this change and please run more benchmarks so we can tune this number later

Jeffwan avatar Mar 18 '25 21:03 Jeffwan

We will leave base case to be 120s and provide an option for user to change config using production overlay.

varungup90 avatar Mar 24 '25 18:03 varungup90