aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

KubeRay dependency ENABLE_PROBES_INJECTION value is wrong

Open Jeffwan opened this issue 9 months ago • 1 comments

🐛 Describe the bug

          env:
            - name: ENABLE_PROBES_INJECTION
              value: '"false"'

this won't take effect. We need to remove the single quote

The problem is it still inject the probes but it may introduce problems if the model is too large and the probe may kill the container.

Steps to Reproduce

just deploy the aibrix-dependencies

Expected behavior

probe should not be injected

Environment

  • AIBrix version: v0.2.0

Jeffwan avatar Mar 01 '25 07:03 Jeffwan

the problem is it didn't disable the probe injection successfully. For most of the case, this is ok but for large model, probe may kill the pod and can not wait for model to be downloaded.

Jeffwan avatar Mar 02 '25 18:03 Jeffwan