aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

Use native codegen cmd generating client-go

Open kerthcet opened this issue 10 months ago • 2 comments

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

comment: https://github.com/vllm-project/aibrix/pull/713/files#r1968598195

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • [ ] PR title includes appropriate prefix(es)
  • [ ] Changes are clearly explained in the PR description
  • [ ] New and existing tests pass successfully
  • [ ] Code adheres to project style and best practices
  • [ ] Documentation updated to reflect changes (if applicable)
  • [ ] Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

kerthcet avatar Feb 25 '25 09:02 kerthcet

It's based on https://github.com/vllm-project/aibrix/pull/740, let's merge https://github.com/vllm-project/aibrix/pull/740 first.

kerthcet avatar Feb 25 '25 10:02 kerthcet

@kerthcet #740 is merged. Seems the CI is problematic, it doesn't detect the conflicts now. Please help rebase the change

Jeffwan avatar Feb 25 '25 18:02 Jeffwan

@kerthcet #740 is merged. Seems the CI is problematic, it doesn't detect the conflicts now. Please help rebase the change

I cherry-picked the commit, so conflict may not happen. Ready to merge now.

kerthcet avatar Feb 26 '25 03:02 kerthcet

Sounds good

Jeffwan avatar Feb 26 '25 03:02 Jeffwan