aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

Intermittently CI test is skipped in PR

Open gangmuk opened this issue 10 months ago • 4 comments

🐛 Describe the bug

Intermittently CI test is skipped in PR. Couldn't figure out when and why it happens.

Leaving issue for future reference.

Image Image

Steps to Reproduce

In local repo, I squashed two commits and force push to update the existing two commits in remote repo.

The branch was already in open PR.

For the second pushing that I did after squashing two commits locally, the CI test was not triggered.

Expected behavior

Doing CI check?

Environment

0.2.0

gangmuk avatar Feb 25 '25 02:02 gangmuk

@gangmuk did your first commit trigger the test?

Check jobs trigger condition

  • https://github.com/vllm-project/aibrix/blob/main/.github/workflows/lint-and-tests.yml
  • https://github.com/vllm-project/aibrix/blob/main/.github/workflows/installation-tests.yml

I feel the benchmark folder may not trigger any test at this moment

Jeffwan avatar Feb 25 '25 02:02 Jeffwan

@Jeffwan Hmm. I think it was triggered. I will see next time I push benchmarks

gangmuk avatar Feb 25 '25 05:02 gangmuk

Sure. Let's keep this open and revisit it later

Jeffwan avatar Feb 25 '25 05:02 Jeffwan

@Jeffwan you are right. I made another PR under benchmarks dir. It didn't trigger the CI test.

this is the current workflow/installation-tests.yml. which it seems not including benchmarks path. Is it expected? I can make a PR for it if it is unintended. Image

gangmuk avatar Feb 28 '25 20:02 gangmuk

I think the root cause above is the folder not in the tracked paths.

Since benchmark code is not part of the e2e test. I think we do not need to include the folder in the CI yet. Until benchmark is part of the CI process.

This could be closed now

Jeffwan avatar Apr 28 '25 21:04 Jeffwan