aibrix icon indicating copy to clipboard operation
aibrix copied to clipboard

[FIX] fixing bug in using AsyncOpenAI client (header setting, token counting, etc)

Open gangmuk opened this issue 10 months ago • 1 comments

Pull Request Description

This PR fixes a few bugs in client and also improves failure request handling. Bugs

  • Header setting in AsyncOpenAI was not being done (routing-strategy header)
  • It was counting the number of output tokens in a wrong way in streaming client.

Improvement

  • Handling failure request in a better way

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • [ ] PR title includes appropriate prefix(es)
  • [ ] Changes are clearly explained in the PR description
  • [ ] New and existing tests pass successfully
  • [ ] Code adheres to project style and best practices
  • [ ] Documentation updated to reflect changes (if applicable)
  • [ ] Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

gangmuk avatar Feb 25 '25 02:02 gangmuk

For the CI issue, I left comment here https://github.com/vllm-project/aibrix/issues/739 and please take a look

Jeffwan avatar Feb 25 '25 03:02 Jeffwan